[PATCH 2/2] nfs: Add RPCd task affinity config option

Daniel Cederman cederman at gaisler.com
Thu Nov 13 10:17:50 UTC 2014



On 2014-11-13 10:23, Sebastian Huber wrote:
> On 13/11/14 10:09, Daniel Cederman wrote:
>> @@ -407,6 +410,8 @@ static rtems_interval    ticksPerSec;        /*
>> cached system clock rate (WHO IS ASSUMED
>>                                                */
>>
>>   rtems_task_priority        rpciodPriority = 0;
>> +cpu_set_t            *rpciodCpuset = 0;
>> +size_t                rpciodCpusetSize = 0;
>>
>>   #if (DEBUG) & DEBUG_MALLOC
>>   /* malloc wrappers for debugging */
>
> Missing #ifdef RTEMS_SMP ?
>
> I am not sure if we should really use #ifdef RTEMS_SMP for the #include
> <sys/cpuset.h>.  We use also #if defined(__RTEMS_HAVE_SYS_CPUSET_H__) &&
> defined(RTEMS_SMP) sometimes.  I would simply force users to update
> their Newlib version.
>
> Please fix the spacing and use the coding style of the file.
>

Thank you for you comments. I removed the #ifdef RTEMS_SMP around 
<sys/cpuset.h> and have hopefully fixed the spacing issues. I will 
submit new versions of the patches.

-- 
Daniel Cederman
Software Engineer
Aeroflex Gaisler AB
Aeroflex Microelectronic Solutions – HiRel
Kungsgatan 12
SE-411 19 Gothenburg, Sweden
Phone: +46 31 7758665
cederman at gaisler.com
www.Aeroflex.com/Gaisler



More information about the devel mailing list