[PATCH 04/22] dosfs: Avoid MIN() re-definition

Peter Dufault dufault at hda.com
Fri Nov 21 12:38:51 UTC 2014


Much better, thanks.  I should have read all the email first, I was getting caught up on the last few days.  I recall you asked about doing that.

> On Nov 21, 2014, at 06:11 , Sebastian Huber <sebastian.huber at embedded-brains.de> wrote:
> 
> On 21/11/14 11:26, Peter Dufault wrote:
>> I don't like these kind of "ifndef" tests before defining something because how do you know it was defined compatibly?  Granted MIN is well-known so that's less likely than other uses of this pattern.
>> 
>> Can the definition be made identical to the other definition to eliminate a warning or does GCC still warn about a redefinition?
> 
> I fixed it this way:
> 
> http://git.rtems.org/rtems/commit/?id=11925eef789566a226d8eaacbceb4d89df787ebc

Peter
-----------------
Peter Dufault
HD Associates, Inc.      Software and System Engineering




More information about the devel mailing list