[PATCH 50/52] cpukit/score/src/ts64*: Return a value from non-void function

Joel Sherrill joel.sherrill at oarcorp.com
Wed Oct 8 20:29:50 UTC 2014


Adding Hesham
On 10/8/2014 3:22 PM, Gedare Bloom wrote:
> How did this stuff ever work, is it tested anywhere?
This only showed up on the or1k build. I can only hope this
explained some of his failures.

Or.. the return value was just laying around in a register. :)
> -Gedare
>
> On Wed, Oct 8, 2014 at 3:16 PM, Joel Sherrill <joel.sherrill at oarcorp.com> wrote:
>> ---
>>  cpukit/score/src/ts64equalto.c        | 2 +-
>>  cpukit/score/src/ts64getnanoseconds.c | 2 +-
>>  cpukit/score/src/ts64getseconds.c     | 2 +-
>>  cpukit/score/src/ts64lessthan.c       | 2 +-
>>  4 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/cpukit/score/src/ts64equalto.c b/cpukit/score/src/ts64equalto.c
>> index 28c6fa4..fd07474 100644
>> --- a/cpukit/score/src/ts64equalto.c
>> +++ b/cpukit/score/src/ts64equalto.c
>> @@ -26,6 +26,6 @@ bool _Timestamp64_Equal_to(
>>    const Timestamp64_Control *_rhs
>>  )
>>  {
>> -  _Timestamp64_implementation_Equal_to( _lhs, _rhs );
>> +  return _Timestamp64_implementation_Equal_to( _lhs, _rhs );
>>  }
>>  #endif
>> diff --git a/cpukit/score/src/ts64getnanoseconds.c b/cpukit/score/src/ts64getnanoseconds.c
>> index 65a0b62..a5da43b 100644
>> --- a/cpukit/score/src/ts64getnanoseconds.c
>> +++ b/cpukit/score/src/ts64getnanoseconds.c
>> @@ -25,6 +25,6 @@ uint32_t _Timestamp64_Get_nanoseconds(
>>    const Timestamp64_Control *_time
>>  )
>>  {
>> -  _Timestamp64_implementation_Get_nanoseconds( _time );
>> +  return _Timestamp64_implementation_Get_nanoseconds( _time );
>>  }
>>  #endif
>> diff --git a/cpukit/score/src/ts64getseconds.c b/cpukit/score/src/ts64getseconds.c
>> index 0f102bc..eca0536 100644
>> --- a/cpukit/score/src/ts64getseconds.c
>> +++ b/cpukit/score/src/ts64getseconds.c
>> @@ -25,6 +25,6 @@ uint32_t _Timestamp64_Get_seconds(
>>    const Timestamp64_Control *_time
>>  )
>>  {
>> -  _Timestamp64_implementation_Get_seconds( _time );
>> +  return _Timestamp64_implementation_Get_seconds( _time );
>>  }
>>  #endif
>> diff --git a/cpukit/score/src/ts64lessthan.c b/cpukit/score/src/ts64lessthan.c
>> index 5c518c0..d147814 100644
>> --- a/cpukit/score/src/ts64lessthan.c
>> +++ b/cpukit/score/src/ts64lessthan.c
>> @@ -26,6 +26,6 @@ bool _Timestamp64_Less_than(
>>    const Timestamp64_Control *_rhs
>>  )
>>  {
>> -  _Timestamp64_implementation_Less_than( _lhs, _rhs );
>> +  return _Timestamp64_implementation_Less_than( _lhs, _rhs );
>>  }
>>  #endif
>> --
>> 1.9.3
>>
>> _______________________________________________
>> devel mailing list
>> devel at rtems.org
>> http://lists.rtems.org/mailman/listinfo/devel

-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill at OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
Support Available                (256) 722-9985



More information about the devel mailing list