Batch of Patches from Joel

Gedare Bloom gedare at rtems.org
Mon Oct 13 15:51:01 UTC 2014


On Mon, Oct 13, 2014 at 11:18 AM, Joel Sherrill
<joel.sherrill at oarcorp.com> wrote:
>
> On 10/13/2014 9:48 AM, Gedare Bloom wrote:
>> These 23 look good to me. -Gedare
> Thanks. I know this many patches is a real pain but it
> is unfortunately needed to get the warning count down.
>
> The unique warning count has dropped from ~1750 to
> ~800 in the past week. Of those ~800, there are still
> 533 "no previous prototypes" left to look at.  I am
> sticking to adding static or addressing .h files but we
> still have to figure out what to do about C methods
> that are only referenced from .S files. :)
>
The prototypes can still go into a header file, which could even be
included by the .S file (with appropriate guards) to expose the
dependency.

-Gedare

> NOTE: For defaults for weak symbols, I am just adding
> a prototype to the C file.
>
> Committing. Thanks.
>
> --joel
>
>> On Mon, Oct 13, 2014 at 10:13 AM, Joel Sherrill
>> <joel.sherrill at oarcorp.com> wrote:
>>> Hi
>>>
>>> It was rainy here over the weekend and I hacked at warnings.
>>> I have a branch with 80 patches pending. That is obviously
>>> too much to send to devel in one batch. This is the first
>>> batch of 23 and these are the more unique patches and
>>> a couple of cases of "apply a pattern"
>>>
>>> + Clean up, then remove mips/clock because it was not even compiled
>>> + delete unused rtems_shell_cp_exit()
>>> + PowerPC bootloader patch round 2 to address Gedare's comments
>>> + add <bsp/bootcard.h> to files where that fixed warnings
>>> + eliminate odd and unused debug methods from some m68k consoles
>>>
>>> Beyond this, the next patch of patches will be the same old warning
>>> removal tricks and clean up. Make things static, correct types, etc.
>>>
>>> --
>>> Joel Sherrill, Ph.D.             Director of Research & Development
>>> joel.sherrill at OARcorp.com        On-Line Applications Research
>>> Ask me about RTEMS: a free RTOS  Huntsville AL 35805
>>> Support Available                (256) 722-9985
>>>
>>>
>>> _______________________________________________
>>> devel mailing list
>>> devel at rtems.org
>>> http://lists.rtems.org/mailman/listinfo/devel
>
> --
> Joel Sherrill, Ph.D.             Director of Research & Development
> joel.sherrill at OARcorp.com        On-Line Applications Research
> Ask me about RTEMS: a free RTOS  Huntsville AL 35805
> Support Available                (256) 722-9985
>


More information about the devel mailing list