[PATCH 1/2] libcpu/or1k: Fix warnings.

Gedare Bloom gedare at rtems.org
Fri Oct 10 17:04:25 UTC 2014


Just one note, I prefer to see addresses cast to uintptr_t.

On Fri, Oct 10, 2014 at 12:44 PM, Hesham ALMatary
<heshamelmatary at gmail.com> wrote:
> ---
>  c/src/lib/libcpu/or1k/shared/cache/cache.c  | 16 ++++++++--------
>  c/src/lib/libcpu/or1k/shared/cache/cache_.h |  1 +
>  2 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/c/src/lib/libcpu/or1k/shared/cache/cache.c b/c/src/lib/libcpu/or1k/shared/cache/cache.c
> index 039be36..d38b572 100644
> --- a/c/src/lib/libcpu/or1k/shared/cache/cache.c
> +++ b/c/src/lib/libcpu/or1k/shared/cache/cache.c
> @@ -71,7 +71,7 @@ static inline void _CPU_OR1K_Cache_data_block_prefetch(const void *d_addr)
>
>    _ISR_Disable (level);
>
> -  _OR1K_mtspr(CPU_OR1K_SPR_DCBPR, d_addr);
> +  _OR1K_mtspr(CPU_OR1K_SPR_DCBPR, (uint32_t) d_addr);
>
>    _ISR_Enable(level);
>  }
> @@ -81,7 +81,7 @@ static inline void _CPU_OR1K_Cache_data_block_flush(const void *d_addr)
>     ISR_Level level;
>    _ISR_Disable (level);
>
> -  _OR1K_mtspr(CPU_OR1K_SPR_DCBFR, d_addr);
> +  _OR1K_mtspr(CPU_OR1K_SPR_DCBFR, (uint32_t) d_addr);
>
>    _ISR_Enable(level);
>  }
> @@ -91,7 +91,7 @@ static inline void _CPU_OR1K_Cache_data_block_invalidate(const void *d_addr)
>     ISR_Level level;
>    _ISR_Disable (level);
>
> -  _OR1K_mtspr(CPU_OR1K_SPR_DCBIR, d_addr);
> +  _OR1K_mtspr(CPU_OR1K_SPR_DCBIR, (uint32_t) d_addr);
>
>    _ISR_Enable(level);
>  }
> @@ -101,7 +101,7 @@ static inline void _CPU_OR1K_Cache_data_block_writeback(const void *d_addr)
>     ISR_Level level;
>    _ISR_Disable (level);
>
> -  _OR1K_mtspr(CPU_OR1K_SPR_DCBWR, d_addr);
> +  _OR1K_mtspr(CPU_OR1K_SPR_DCBWR, (uint32_t) d_addr);
>
>    _ISR_Enable(level);
>  }
> @@ -111,7 +111,7 @@ static inline void _CPU_OR1K_Cache_data_block_lock(const void *d_addr)
>     ISR_Level level;
>    _ISR_Disable (level);
>
> -  _OR1K_mtspr(CPU_OR1K_SPR_DCBLR, d_addr);
> +  _OR1K_mtspr(CPU_OR1K_SPR_DCBLR, (uint32_t) d_addr);
>
>    _ISR_Enable(level);
>  }
> @@ -122,7 +122,7 @@ static inline void _CPU_OR1K_Cache_instruction_block_prefetch
>     ISR_Level level;
>    _ISR_Disable (level);
>
> -  _OR1K_mtspr(CPU_OR1K_SPR_ICBPR, d_addr);
> +  _OR1K_mtspr(CPU_OR1K_SPR_ICBPR, (uint32_t) d_addr);
>
>    _ISR_Enable(level);
>  }
> @@ -133,7 +133,7 @@ static inline void _CPU_OR1K_Cache_instruction_block_invalidate
>     ISR_Level level;
>    _ISR_Disable (level);
>
> -  _OR1K_mtspr(CPU_OR1K_SPR_ICBIR, d_addr);
> +  _OR1K_mtspr(CPU_OR1K_SPR_ICBIR, (uint32_t) d_addr);
>
>    _ISR_Enable(level);
>  }
> @@ -144,7 +144,7 @@ static inline void _CPU_OR1K_Cache_instruction_block_lock
>     ISR_Level level;
>    _ISR_Disable (level);
>
> -  _OR1K_mtspr(CPU_OR1K_SPR_ICBLR, d_addr);
> +  _OR1K_mtspr(CPU_OR1K_SPR_ICBLR, (uint32_t) d_addr);
>
>    _ISR_Enable(level);
>  }
> diff --git a/c/src/lib/libcpu/or1k/shared/cache/cache_.h b/c/src/lib/libcpu/or1k/shared/cache/cache_.h
> index 5f08410..0ea939f 100644
> --- a/c/src/lib/libcpu/or1k/shared/cache/cache_.h
> +++ b/c/src/lib/libcpu/or1k/shared/cache/cache_.h
> @@ -6,6 +6,7 @@
>  #define __OR1K_CACHE_H
>
>  #include <bsp/cache_.h>
> +#include <libcpu/cache.h>
>
>  #endif
>  /* end of include file */
> --
> 1.9.3
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel



More information about the devel mailing list