TMS570 headers ready for review

[Gedare Bloom]

On Tue, Jun 2, 2015 at 9:39 AM, Pavel Pisa <pisa at cmp.felk.cvut.cz> wrote:
> Hello all,
>
> Premysl Houdek has prepared new and hopefully near ready
> complete header files for TMS570LS3137 microcontroller.
> They are based on PDF documentation and license is
> RTEMS compatible. The scripts used during process can be
> found in
>
>   https://github.com/AoLaD/rtems-tms570-utils/tree/headers/headers/python
>
> The RTEMS updated and compiled with actual headers can be
> found in his tms570-bsp branch
>
>   https://github.com/AoLaD/rtems/tree/tms570-bsp/c/src/lib/libbsp/arm/tms570/include
>
> Please, look on the files and express your opinion.
> The new temporary top level header files is tms5702.h.
> It should replace tms570.h.
>
I took a glance at some, I didn't see anything overtly bad, although
the generated license is (1) interleaved with excess newlines, and (2)
possibly spurious to apply on automatically generated content. The
script he wrote should specify itself what the license is on generated
files. I'd recommend something that is as permissive as possible when
dealing with generated files.

I'll be curious to see what tms570 users think of the generated headers.

> As for the header files organization, we propose to
> move peripherals registers header files to the
> subdirectory of BSP include path. But because Texas Instruments
> IP blocks can appear even on slightly modified chips we
> do not propose tms570 name. Our idea is to use "tmsreg" name
> and use peripherals headers file names in lowercase form.
> The files would be generally included from code through
> "tms570.h".
>
I'm fine with the more generic use of names, although I might prefer
separation of tms_reg. We also have some generic BSPs that span
multiple boards, and I think we prefer something like generic_tms_...
now, e.g. generic_or1k was recently added. Older generic code used
something more like gen5200. If the IP blocks may be unrelated to the
TMS line however, it might be sensible to have something more like
generic_ti_...

However, until the code is actually shared by multiple BSPs, I might
prefer to see it kept local to the tms570.

> Do you agree with proposal?
> Have you some more ideas?
>
> The adjustment of actual BSP sources for the new header files
> is minimal. See separate commits. The BSP builds completely
> with all examples. We plan more testing in next days.
>
A document of what/how testing was done would be nice, and a
relatively good (English) report about the whole process would help I
think, if time and energy permit.

> Best wishes,
>
>               Pavel
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel