libbsd Makefile issues

[Gene Smith]

On 06/23/2015 02:18 PM, Joel Sherrill wrote:
>
>
> On 6/23/2015 1:09 PM, Gene Smith wrote:
>>
>> Here's the things I did to fix the Makefile. I think you added the
>> quotes (item 1) and maybe item 2. I think the error you are seeing is
>> due to item 3 since it can't find pcap.h.
>>
>> 1) Everywhere the string "-D_U_=__attribute__((unused))" appears in the
>> rules it needs to be quoted. It appears in almost every rule so there
>> are maybe 100s of them. (I used single quotes, FWIW.)
>>
>> 2) Everywhere sting "freebsd/usr.sbin/tcpdump/tcpdump-D__FreeBSD__=1"
>> appears it needs have a space inserted:
>> "freebsd/usr.sbin/tcpdump/tcpdump -D__FreeBSD__=1"
>> Quotes aren't required. Again, there a many of these.
>>
>> 3) Several include paths need to be added:
>> COMMON_FLAGS += -Ifreebsd/contrib/libpcap
>> COMMON_FLAGS += -Irtemsbsd/sys
>> COMMON_FLAGS += -Ifreebsd/usr.sbin/tcpdump/tcpdump
>> COMMON_FLAGS += -Ifreebsd/contrib/tcpdump
>> COMMON_FLAGS +=
>> -Ibuild/arm-rtems4.11-realview_pbx_a9_qemu/testsuite/include
>> (The last one contains the bsp name so probably needs to be more
>> general, but seems to work ok as an ad hoc fix.)
>
> I could repeat those steps but if you have a patch, I am
> happy to push it.
>
> Please.. patch. :)
>
> Is it working for you on some target?
>

It basically works on realview with qemu but the last COMMON_FLAGS 
addition for include paths will break it for other bsp's I suspect. But 
I will send the patch via private email since it is quite large.

-gene