[PATCH] arm: mx6ulevk: Initial BSP support for i.MX 6UltraLite EVK board.

[Peng Fan]

Thanks Joel and Gedare for the comments.

For "Did you "clone and own" anything from another BSP? "
If you are asking me to add the copyright back, I'll check to avoid
discarding the copyrights.

Thanks,
Peng.

2016-04-19 23:47 GMT+08:00 Joel Sherrill <joel at rtems.org>:

>
>
> On Tue, Apr 19, 2016 at 10:41 AM, Gedare Bloom <gedare at rtems.org> wrote:
>
>> On Tue, Apr 19, 2016 at 9:59 AM, Joel Sherrill <joel at rtems.org> wrote:
>> > A few quick things.
>> >
>> > Add a bspimpl.h which is private to the bsp. Do not put anything in
>> bsp.h
>> > which
>> > does not need to be public to the application. We have been exceedingly
>> > uncaring about this in the past and the software tax to correct it is
>> going
>> > to
>> > be painful. In general, the bsp.h probably doesn't need much except to
>> > provide the BSP defaults for confdefs.h if it needs to change them.
>> > And no.. there aren't any great examples yet.
>> >
>>
>> Another point is to check the current .cfg files for examples of how
>> to add the per-function and per-sections LTO
>>
>
> +1 that would be a good think for the script to check.
>
> As well as for the console table structure Sebastian recommended not using.
>
> Also the new code should be warning free. It should also not result in
> warnings in formerly warning free shared code.
>
> The script isn't great but if we can use grep to help us review for
> repeat offenders, then we can focus on harder issues.
>
> --joel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20160420/338baea5/attachment.html>