[PATCH 4/4] Added ethernet support for Raspberry Pi. USB DMA related functions commented out, since DMA support for raspberry is underdevelopment.

[Deval Shah]

On Fri, Aug 19, 2016 at 2:51 PM, Sebastian Huber <
sebastian.huber at embedded-brains.de> wrote:

> I updated the rules to modify FreeBSD code. Please follow them. In
> particular we have:
>
> "Add nothing (even blank lines) before or after the |__rtems__| guards.
> Always include a |__rtems__| in the guards"
>

Actually in some places while adding the |__rtems__| guards, some blank
lines were getting deleted. So the first rule was beig violated. "Only add
lines.  If your patch contains lines starting with a '-', then this is
wrong."

I will correct the other mistakes. i.e. adding the guards at the begining
of the line and including /* __rtems__ */ in the guards.


> Please don't merge changes for a particular BSP and generic changes into
> one commit.


I will correct that.

Any other thing which I should keep in mind before submitting the final
patches ?

Also, do I have to send all the patches again ? or just the ones which I
will add now.

>
>
> On 19/08/16 10:46, Deval Shah wrote:
>
>> ---
>>   freebsd/sys/dev/usb/net/if_smsc.c                  | 44
>> ++++++++++++++++++++++
>>   freebsd/sys/dev/usb/net/if_smscreg.h               |  1 +
>>   freebsd/sys/dev/usb/net/usb_ethernet.c             | 17 +++++++++
>>   freebsd/sys/sys/sysctl.h                           |  1 +
>>   rtemsbsd/include/bsp/nexus-devices.h               |  2 +
>>   rtemsbsd/include/machine/rtems-bsd-nexus-bus.h     | 18 +++++++++
>>   .../include/rtems/bsd/test/network-config.h.in     |  2 +
>>   7 files changed, 85 insertions(+)
>>
>
> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de
> PGP     : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
>


-- 
Deval Shah
Graduate Student,
B.E. (Hons.) Electrical and Electronics Engineering
BITS Pilani Hyderabad Campus <http://www.bits-pilani.ac.in/hyderabad/>

Github Profile <https://github.com/deval-maker>
ᐧ
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20160819/5b1127f3/attachment.html>