general comments on sysiinit patches

[Sebastian Huber]

On 02/02/16 10:04, Chris Johns wrote:
> [ Sorry, laptop slipped and it sent the email ... ]
>
> On 2/02/2016 9:49 PM, Chris Johns wrote:
>> >On 2/02/2016 7:25 PM, Sebastian Huber wrote:
>>> >>
>>>> >>>
>>>> >>>How do we want to proceed? Chris, what is your opinion with respect to
>>>> >>>this EXTERN magic?
>>>> >>>
>>>> >>>some.h
>>>> >>>
>>>> >>>#ifndef SOME_XYZ_EXTERN
>>>> >>>#define SOME_XYZ_EXTERN extern
>>>> >>>#endif
>>>> >>>
>>>> >>>SOME_XYZ_EXTERN type xyz;
>>>> >>>
>>>> >>>some_xyz.c
>>>> >>>
>>>> >>>#define SOME_XYZ_EXTERN
>>>> >>>#include <some.h>
>>>> >>>
>>>> >>>vs.
>>>> >>>
>>>> >>>some.h
>>>> >>>
>>>> >>>extern type xyz;
>>>> >>>
>>>> >>>some_xyz.c
>>>> >>>
>>>> >>>#include <some.h>
>>>> >>>type xyz;
>>>> >>>
>>> >>
>>> >>We have 2:1 against the EXTERN pattern, so I will commit the patches
>>> >>tomorrow if nobody objects in the meantime.
>>> >>
>> >
>> >I do not object to the patch or the change. The need to discuss the
> .. change is important because the current pattern has been present for
> a long time. We need to be mindful and to show respect when making these
> changes.
>
> I think it is important the global or extern data is declared in a
> uniform manner.

I am in favour to remove the EXTERN pattern completely. After the 
current patch set only SCORE_EXTERN is left. This define covers several 
global variables (in contrast to the manager defines) and I will 
probably have to untangle them later in case I have time for some 
further optimizations.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.