[PATCH 1/2] score: Introduce Thread_Entry_information

[Gedare Bloom]

On Fri, Jan 8, 2016 at 9:39 AM, Sebastian Huber
<sebastian.huber at embedded-brains.de> wrote:
> On 08/01/16 15:37, Sebastian Huber wrote:
>>
>> diff --git a/cpukit/score/include/rtems/score/thread.h
>> b/cpukit/score/include/rtems/score/thread.h
>> index 6e937e3..37f9f4b 100644
>> --- a/cpukit/score/include/rtems/score/thread.h
>> +++ b/cpukit/score/include/rtems/score/thread.h
>> @@ -89,16 +89,6 @@ extern "C" {
>>   typedef Timestamp_Control Thread_CPU_usage_t;
>>     /**
>> - *  The following defines the "return type" of a thread.
>> - *
>> - *  @note  This cannot always be right.  Some APIs have void
>> - *         tasks/threads, others return pointers, others may
>> - *         return a numeric value.  Hopefully a pointer is
>> - *         always at least as big as an uint32_t  .:)
>> - */
>> -typedef void *Thread;
>> -
>> -/**
>>    *  @brief Type of the numeric argument of a thread entry function with
>> at
>>    *  least one numeric argument.
>>    *
>
>
> I am not sure if we should keep this supposed to be internal type for
> backward compatibility. It was used in idle thread prototypes.
>
I think the elimination is fine. Maybe needs to be clearly documented
in release notes if there is a breakage implied in some user BSPs that
might have used it.

If i understood the patch correctly you are separating out the 3 cases
of kinds of thread entry arguments and providing explicit struct for
each one so they can be type-checked? Looks good to me.

> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de
> PGP     : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel