libbsd / waf: Broken --show-commands support

[Christian Mauderer]

Am 09.07.2016 um 06:45 schrieb Chris Johns:
> On 8/07/2016 6:34 PM, Christian Mauderer wrote:
>>
>> I'm currently trying to port pf to libbsd. While doing that, I wanted to
>> check some of the compiler calls using the waf configure option
>> --show-commands. With the option set, every call went wrong.
>>
>> I was able to track the problem down to the patches introduced with the
>> long command line support. It seems that the command is joined for
>> printing it and than the joined version is given to a python Popen call.
>> As far as I understand the python documentation, Popen expects an array.
> 
> Thanks for this, yes my change to print the number of options broken the
> code.
> 
>> The attached patch fixes this by using a temporary variable for the
>> string that gets printed. Could you review the patch to check that it
>> doesn't break the long command line support again?
> 
> I have built libbsd on MinGW64 and it works so this should be tested.
> 
> I have updated rtems_waf and libbsd.
> 
> Thanks
> Chris
> 

Hello Chris,

thank you for testing and applying the patch.

Kind regards,
Christian

-- 
--------------------------------------------
embedded brains GmbH
Christian Mauderer
Dornierstr. 4
D-82178 Puchheim
Germany
email: christian.mauderer at embedded-brains.de
Phone: +49-89-18 94 741 - 18
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.