PWM driver tested in RTEMS with RGB
punitvara at gmail.com
Sun May 1 02:37:51 UTC 2016
Sorry for late reply. Thank you for your detailed review. I am still
busy this week with my academic work.I would like to have suggestions
on my proposal.
Should I change anything in my proposal like title or any other detail
? Any suggestions ?
Is there any vim setup instruction for RTEMS coding style(i.e Linux
community has). If not ? I would love to develop vim plugin if it is
possible to develop in less time. It will be useful for every RTEMS
On Tue, Apr 26, 2016 at 8:21 PM, Martin Galvan
<martin.galvan at tallertechnologies.com> wrote:
> Hi Punit! Sorry for the delay; I finally got to review your code.
> First and foremost, it'd be great if you could tell us which
> StarterWare version/git commit are you using, so that we can keep it
> handy when reviewing your code. Sorry if you already mentioned it, my
> memory is a bit sketchy these days :)
> As a general comment I'd say you should keep a consistent coding style
> throughout the code you write yourself. While the core RTEMS style
> (spaces after parentheses, etc) isn't required in BSP code, at least
> indentations should be correct. Indentations in RTEMS are usually two
> More on coding style later.
> On Fri, Apr 15, 2016 at 4:48 PM, punit vara <punitvara at gmail.com> wrote:
>> This is my first patch I already sent you when I successfully merged TI SW code.
> I take it you're referring to 0001-add-new-pwm-driver.patch. A few comments:
> 1) Whenever possible, try to keep the original coding style for
> imported code. This makes it easier to track changes and such. Same
> goes for e.g. the order in which functions are declared (e.g.
> EHRPWMConfigureAQActionOnA and B).
> 2) I think you should add the TI license to bbb-pwm.c as well. It
> would also be really nice if you added a comment atop the imported
> files saying which SW version/git commit they come from.
I added Ti licence at last patch. Do I need to add any other licence ?
I will update my local repo with your other suggestion. I considered
all your suggestions. I will soon generate some patches and show you.
Then you can guide me further.
Once again thank you for mentoring every one.
More information about the devel