[PATCH 6/9] Adding USB serial driver test cases

Chris Johns chrisj at rtems.org
Thu Feb 9 03:35:28 UTC 2017


On 09/02/2017 14:21, Kevin Kirspel wrote:
> ---
>  .../include/rtems/bsd/test/default-usb-init.h      | 158 +++++
>  testsuite/usbserial/init.c                         | 373 ++++++++++++
>  testsuite/usbserial01/test_main.c                  | 666 +++++++++++++++++++++
>  testsuite/usbserial02/test_main.c                  | 252 ++++++++
>  testsuite/usbserial03/test_main.c                  | 240 ++++++++
>  testsuite/usbserial04/test_main.c                  | 226 +++++++
>  testsuite/usbserial05/test_main.c                  | 303 ++++++++++
>  testsuite/usbserial06/test_main.c                  | 218 +++++++
>  8 files changed, 2436 insertions(+)
>  create mode 100755 testsuite/include/rtems/bsd/test/default-usb-init.h
>  create mode 100755 testsuite/usbserial/init.c
>  create mode 100755 testsuite/usbserial01/test_main.c
>  create mode 100755 testsuite/usbserial02/test_main.c
>  create mode 100755 testsuite/usbserial03/test_main.c
>  create mode 100755 testsuite/usbserial04/test_main.c
>  create mode 100755 testsuite/usbserial05/test_main.c
>  create mode 100755 testsuite/usbserial06/test_main.c

Can the new termios support in FreeBSD be tested without needing USB 
serial support? In other words, is a separate test for termios possible 
and does it make sense?

My concern is the basic termios functionality being added is not tested 
without having USB serial support which links both parts.

> +++ b/testsuite/usbserial/init.c
> @@ -0,0 +1,373 @@
> +/*
> + * Copyright (c) 2010, 2016 embedded brains GmbH.  All rights reserved.
> + *
> + *  embedded brains GmbH
> + *  Dornierstr. 4
> + *  82178 Puchheim
> + *  Germany
> + *  <rtems at embedded-brains.de>

Is this copyright ok?

I see other places in other patches where this is happening.

Chris



More information about the devel mailing list