[PATCH 6/9] Adding USB serial driver test cases

[Kirspel, Kevin]

We could probably create a tty test driver and convert usbserialXX test cases into termiosXX test cases.  This would delink the two and we would only have the one usbserial test case.  

As far as the copyright, I can change it to whatever you want.  I based the test cases off Sebastian's test structure but I can make a generic RTEMs copyright if needed.

Has anyone had a chance to review the patches in ticket #2897?  A lot of the FREEBSD driver porting related to the tty kernel drivers could be made easier with those patches.  There was one other termios difference that I encountered during testing.  In the RTEMS tcflush() function,  the following call is made

ioctl( fd, RTEMS_IO_TCFLUSH, (intptr_t) queue );

The queue integer is cast to a point instead of being passed by reference.  FREEBSD termios expects this variable to be passed by reference.

One other area that would reduce the porting is support for IO_NDELAY.  If we added "#define IO_NDELAY O_NONBLOCK" somewhere (maybe vnode.h) then all checks for IO_NDELAY would default to O_NONBLOCK which is what RTEMS uses.

Kevin Kirspel
Electrical Engineer - Sr. Staff
Idexx Roswell
235 Hembree Park Drive
Roswell GA 30076
Tel: (770)-510-4444 ext. 81642
Direct: (770)-688-1642
Fax: (770)-510-4445

-----Original Message-----
From: devel [mailto:devel-bounces at rtems.org] On Behalf Of Chris Johns
Sent: Wednesday, February 08, 2017 10:35 PM
To: devel at rtems.org
Subject: Re: [PATCH 6/9] Adding USB serial driver test cases

On 09/02/2017 14:21, Kevin Kirspel wrote:
> ---
>  .../include/rtems/bsd/test/default-usb-init.h      | 158 +++++
>  testsuite/usbserial/init.c                         | 373 ++++++++++++
>  testsuite/usbserial01/test_main.c                  | 666 +++++++++++++++++++++
>  testsuite/usbserial02/test_main.c                  | 252 ++++++++
>  testsuite/usbserial03/test_main.c                  | 240 ++++++++
>  testsuite/usbserial04/test_main.c                  | 226 +++++++
>  testsuite/usbserial05/test_main.c                  | 303 ++++++++++
>  testsuite/usbserial06/test_main.c                  | 218 +++++++
>  8 files changed, 2436 insertions(+)
>  create mode 100755 
> testsuite/include/rtems/bsd/test/default-usb-init.h
>  create mode 100755 testsuite/usbserial/init.c  create mode 100755 
> testsuite/usbserial01/test_main.c  create mode 100755 
> testsuite/usbserial02/test_main.c  create mode 100755 
> testsuite/usbserial03/test_main.c  create mode 100755 
> testsuite/usbserial04/test_main.c  create mode 100755 
> testsuite/usbserial05/test_main.c  create mode 100755 
> testsuite/usbserial06/test_main.c

Can the new termios support in FreeBSD be tested without needing USB serial support? In other words, is a separate test for termios possible and does it make sense?

My concern is the basic termios functionality being added is not tested without having USB serial support which links both parts.

> +++ b/testsuite/usbserial/init.c
> @@ -0,0 +1,373 @@
> +/*
> + * Copyright (c) 2010, 2016 embedded brains GmbH.  All rights reserved.
> + *
> + *  embedded brains GmbH
> + *  Dornierstr. 4
> + *  82178 Puchheim
> + *  Germany
> + *  <rtems at embedded-brains.de>

Is this copyright ok?

I see other places in other patches where this is happening.

Chris
_______________________________________________
devel mailing list
devel at rtems.org
https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.rtems.org_mailman_listinfo_devel&d=DwICAg&c=2do6VJGs3LvEOe4OFFM1bA&r=dbavT-WIJ4nBfQFKYnKdAD52Vyq3ZXSzrL9TAm21lZI&m=cUXCUWnjZb0licBQJbKQXcG2j908Ybve96No5C9F9VE&s=AmSikyKf2BohEKOK8W8d2L2j3NCkav0ECII8hlLwTSQ&e=