[PATCH 2/8] Adding LPC32XX USB OHCI support

Kirspel, Kevin Kevin-Kirspel at idexx.com
Mon Jan 30 13:48:32 UTC 2017


It probably does but here is my reasoning for a new file.

1. The latest FREEBSD master has support for the lpc32xx where the 9.2 branch did not.  It's easy to port the already existing code (i.e. MAC driver, OHCI, MMC, etc...).
2. The ohci_lpc.c driver was not using FREEBSD's bus resources which was different from other drivers.
3. The logic to probe, attach, detach, suspend, and resume was taken from the ohci_lpc.c driver but used the hardware access functions provided by the latest FREEBSD.  

Logically the drivers are the same but the lpc_ohci.c driver uses the FREEBSD LPC interface (with the caveat of the "struct usb_otg_transceiver" interface).  

Ideally the LPC USB OTG I2C code should be moved to an I2C driver.  An USB OTG transceiver driver should be created to probe for the ISP1301/STOTG04E devices.  However, I did not go to this level. 

Kevin Kirspel
Electrical Engineer - Sr. Staff
Idexx Roswell
235 Hembree Park Drive
Roswell GA 30076
Tel: (770)-510-4444 ext. 81642
Direct: (770)-688-1642
Fax: (770)-510-4445

-----Original Message-----
From: Sebastian Huber [mailto:sebastian.huber at embedded-brains.de] 
Sent: Monday, January 30, 2017 1:49 AM
To: Kirspel, Kevin <Kevin-Kirspel at idexx.com>; devel at rtems.org
Subject: Re: [PATCH 2/8] Adding LPC32XX USB OHCI support

We already have an

rtemsbsd/sys/dev/usb/controller/ohci_lpc.c

it used to work with the LPC3200.

On 27/01/17 06:32, Kevin Kirspel wrote:
> ---
>   rtemsbsd/sys/dev/usb/controller/lpc_ohci.c | 495 +++++++++++++++++++++++++++++
>   1 file changed, 495 insertions(+)
>   create mode 100755 rtemsbsd/sys/dev/usb/controller/lpc_ohci.c

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list