[PATCH 1/5] Adding modified FREEBSD headers to sync RTEMS termios with FREEBSD

[Joel Sherrill]

Agreed a BSP or user space code should not use the same name as
anything that is included in POSIX. :)

How did my build sweep miss this?

--joel

On Mon, Mar 20, 2017 at 1:01 PM, Kirspel, Kevin <Kevin-Kirspel at idexx.com>
wrote:

> Actually the best thing to do is change the structure member name and fix
> up any access to that member.
>
>
>
> Kevin Kirspel
>
> Electrical Engineer - Sr. Staff
>
> Idexx Roswell
>
> 235 Hembree Park Drive
>
> Roswell GA 30076
>
> Tel: (770)-510-4444 ext. 81642 <(770)%20510-4444>
>
> Direct: (770)-688-1642 <(770)%20688-1642>
>
> Fax: (770)-510-4445 <(770)%20510-4445>
>
>
>
> *From:* devel [mailto:devel-bounces at rtems.org] *On Behalf Of *Kirspel,
> Kevin
> *Sent:* Monday, March 20, 2017 1:50 PM
> *To:* devel at rtems.org
> *Subject:* RE: [PATCH 1/5] Adding modified FREEBSD headers to sync RTEMS
> termios with FREEBSD
>
>
>
> I tracked the arm failure down to a header file (s3c2410.h) that contains
> a structure that has a member with the same name as a termios #define.
> Re-ordering the include file declarations in each affected C file will fix
> the problem (I’m not sure that’s the best solution but it will do for
> now).  I am going to build all the tool chains so I can check the rest of
> the BSPs.  Sebastian found another issue with a SH BSP.
>
>
>
> Kevin Kirspel
>
> Electrical Engineer - Sr. Staff
>
> Idexx Roswell
>
> 235 Hembree Park Drive
>
> Roswell GA 30076
>
> Tel: (770)-510-4444 ext. 81642 <(770)%20510-4444>
>
> Direct: (770)-688-1642 <(770)%20688-1642>
>
> Fax: (770)-510-4445 <(770)%20510-4445>
>
>
>
> *From:* Joel Sherrill [mailto:joel at rtems.org <joel at rtems.org>]
> *Sent:* Monday, March 20, 2017 1:33 PM
> *To:* Kirspel, Kevin <Kevin-Kirspel at idexx.com>
> *Cc:* devel at rtems.org
> *Subject:* Re: [PATCH 1/5] Adding modified FREEBSD headers to sync RTEMS
> termios with FREEBSD
>
>
>
> I just built all BSPs and didn't see any failures.
>
>
>
> Sebastian.. what was going on with the build you saw fail?
>
>
>
> --joel
>
>
>
> On Mon, Mar 20, 2017 at 9:19 AM, Joel Sherrill <joel at rtems.org> wrote:
>
>
>
>
>
> On Tue, Mar 14, 2017 at 8:54 AM, Kirspel, Kevin <Kevin-Kirspel at idexx.com>
> wrote:
>
> I tested it against xilinx_zynq_a9_qemu.  I'm not sure it exists, but if
> there is a way to compile the patch against every (or most) BSP then we
> could ensure no BSP is broken.
>
>
>
> There are scripts in rtems-testing/rtems to ease testing of a single
> configuation
>
> on all BSPs. Or a variety of configurations on a single BSP. I use them to
>
> generate the warnings reports that I periodically announce.
>
>
>
> I am seeing if all BSPs build now. Give me a few hours.
>
>
>
> --joel
>
>
>
> Kevin Kirspel
> Electrical Engineer - Sr. Staff
> Idexx Roswell
> 235 Hembree Park Drive
> Roswell GA 30076
> Tel: (770)-510-4444 ext. 81642
> Direct: (770)-688-1642
> Fax: (770)-510-4445
>
>
> -----Original Message-----
> From: Sebastian Huber [mailto:sebastian.huber at embedded-brains.de]
> Sent: Tuesday, March 14, 2017 9:42 AM
> To: Kirspel, Kevin <Kevin-Kirspel at idexx.com>; devel at rtems.org
> Subject: Re: [PATCH 1/5] Adding modified FREEBSD headers to sync RTEMS
> termios with FREEBSD
>
> The patch set looks good after a rough review. I will check this in in two
> or three days if nobody objects.
>
> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de
> PGP     : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
> <https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.rtems.org_mailman_listinfo_devel&d=DwMFaQ&c=2do6VJGs3LvEOe4OFFM1bA&r=HDiJ93ANMEQ32G5JGdpyUxbdebuwKHBbeiHMr3RbR74&m=Rh9qB1wyRTbNNWuecoD2ZnxQG4zzUt_g-GM295-SibA&s=DM2kkkY3t3lj7LgOPBCejJ85dfSKMbJxO7971XSRMJI&e=>
>
>
>
>
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20170320/7d13e55b/attachment-0002.html>