[PATCH] cpukit: Fix __RTEMS_REVISION__ define

[Sebastian Huber]

On 03/05/17 08:17, Chris Johns wrote:
> On 3/5/17 3:40 pm, Sebastian Huber wrote:
>> On 03/05/17 07:28, Chris Johns wrote:
>>> On 3/5/17 3:09 pm, Sebastian Huber wrote:
>>>> On 02/05/17 23:30, Chris Johns wrote:
>>>>> On 2/5/17 6:20 pm, Sebastian Huber wrote:
>>>>> [...]
>>>>> If you want to add this test please extract the version details from
>>>>> the
>>>>> build system
>>>> Can we trust the build system?
>>>>
>>> Given the header file with the values it created by the build system yes
>>> we can.
>> I don't think we can trust the build system. The requirement for a
>> release is that the version macros should have specific values. We
>> should test that this is the case.
> We have to trust the build system for a clean or fresh build and if we
> cannot not it is a bug. To state otherwise expands the scope of
> uncertainty and I do not believe we need too.
>
> I will state again, doing this breaks the release process. I am sorry
> but this is just now the release model and supporting configuration
> control structures exist.

I still don't see how this breaks the release process. One task of it is 
surly to change the version from N to N + 1. This requires to modify 
some files (with a script). This test would be just one of these files. 
Some are *.m4 files, some *.c files, it doesn't matter.

>
>> Maybe we have some time in the future something like this:
>>
>> Requirement 2341: There shall be a C pre-processor define
>> __RTEMS_MAJOR__ available via #include <rtems.h> defined to 123.
> I doubt this would be in the RTEMS Project's requirements. It might be
> in a qualification package for the specific qualification effort.

It is a RTEMS Project's requirement. Its just not explicitly stated. If 
you release RTEMS 3.4.531 a user expects to have

#define __RTEMS_MAJOR__ 3
#define __RTEMS_MINOR__ 4
#define __RTEMS_REVISION__ 531

> How
> that define it created is for the RTEMS Project to determine.

Yes, but somehow the define must exist with the right value and this is 
what needs to be tested.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.