[PATCH] confdefs.h: Add SMP enabled field to configuration
Sebastian Huber
sebastian.huber at embedded-brains.de
Fri May 12 09:39:34 UTC 2017
On 12/05/17 11:20, Sebastian Huber wrote:
> On 12/05/17 11:15, Joel Sherrill wrote:
>>
>>
>> On May 12, 2017 3:44 AM, "Sebastian Huber"
>> <sebastian.huber at embedded-brains.de
>> <mailto:sebastian.huber at embedded-brains.de>> wrote:
>>
>> On 12/05/17 10:39, Chris Johns wrote:
>>
>> On 12/05/2017 18:11, Sebastian Huber wrote:
>>
>> Do not use the processor count to determine if SMP is
>> enabled. Instead
>> use a dedicated configuration option. Enable SMP by
>> default in SMP
>> configurations.
>>
>> Add CONFIGURE_DISABLE_SMP_CONFIGURATION to all test which
>> would fail
>> otherwise.
>>
>>
>> I think adding a comment to the test explaining the reason
>> would be good to have.
>>
>>
>> This is a new issue and not a 4.12 release blocker from my point
>> of view:
>>
>> https://devel.rtems.org/ticket/3020
>> <https://devel.rtems.org/ticket/3020>
>>
>>
>> This does not address Chris' question. Whether a blocker or not, it
>> needs a comment for each test.
>
> Yes, see the new ticket. The question is when you add a comment.
>
>> You can't add this patch without the comments before or after branching.
>
> I don't have time to go through 35 tests to look why they don't work
> in an SMP configuration at the moment. If we want to release 4.12 some
> time in the future we should really identify the blocking issues,
> otherwise the release will never happen.
>
Maybe we should do this:
#warning "https://devel.rtems.org/ticket/3020"
#define CONFIGURE_DISABLE_SMP_CONFIGURATION
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber at embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
More information about the devel
mailing list