[PATCH v2] build: Make entering the directories silent when building silent.

[Amaan Cheval]

On Fri, Apr 13, 2018 at 5:49 AM Chris Johns <chrisj at rtems.org> wrote:

> ---
>   c/src/automake/subdirs.am      | 3 ++-
>   cpukit/automake/subdirs.am     | 3 ++-
>   testsuites/automake/subdirs.am | 3 ++-
>   3 files changed, 6 insertions(+), 3 deletions(-)

> diff --git a/c/src/automake/subdirs.am b/c/src/automake/subdirs.am
> index 47d88cffcd..ef758f076d 100644
> --- a/c/src/automake/subdirs.am
> +++ b/c/src/automake/subdirs.am
> @@ -29,7 +29,8 @@ $1:
>          if test "$$$$target" = "all-local"; then \
>            target="all"; \
>          fi; \
> -       echo "Making $$$$target in $$$$subdir"; \
> +       if test x$(AM_V_P) != x; then silent=$(AM_V_P); else
silent=false; fi; \
> +       if $$$$silent; then echo "Making $$$$target in $$$$subdir"; fi; \

Though this does the right thing, it reads misleadingly - "if silent, then
echo". Should it be named "verbose", perhaps, or be negated if it's meant
to be easy to search for "silent" for all instances where the silent
building takes effect? (The latter depends on how AM_V_P is set, which I'm
not sure about.)

>          if test "$$$$subdir" != "."; then \
>            cd $$$$subdir; \
>            $(MAKE) $(AM_MAKEFLAGS) $$$$target; \
> diff --git a/cpukit/automake/subdirs.am b/cpukit/automake/subdirs.am
> index b36ad80735..dde2cf4403 100644
> --- a/cpukit/automake/subdirs.am
> +++ b/cpukit/automake/subdirs.am
> @@ -28,7 +28,8 @@ $1: $(preintstall_targets)
>          if test "$$$$target" = "all-local"; then \
>            target="all"; \
>          fi; \
> -       echo "Making $$$$target in $$$$subdir"; \
> +       if test x$(AM_V_P) != x; then silent=$(AM_V_P); else
silent=false; fi; \
> +       if $$$$silent; then echo "Making $$$$target in $$$$subdir"; fi; \
>          if test "$$$$subdir" != "."; then \
>            cd $$$$subdir; \
>            $(MAKE) $(AM_MAKEFLAGS) $$$$target; \
> diff --git a/testsuites/automake/subdirs.am b/testsuites/automake/
subdirs.am
> index a566774bab..31ff284e4d 100644
> --- a/testsuites/automake/subdirs.am
> +++ b/testsuites/automake/subdirs.am
> @@ -16,7 +16,8 @@ $1:
>            if test "$$$$target" = "all-local"; then \
>              target="all"; \
>            fi; \
> -         echo "Making $$$$target in $(1)"; \
> +         if test x$(AM_V_P) != x; then silent=$(AM_V_P); else
silent=false; fi; \
> +         if $$$$silent; then echo "Making $$$$target in $$(1)"; fi; \
>            cd $(1); \
>            $(MAKE) $(AM_MAKEFLAGS) TEST_FLAGS="$$$$test_FLAGS" $$$$target;
\
>          fi;
> --
> 2.15.1

> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel