[PATCH v2] build: Make entering the directories silent when building silent.

[Chris Johns]

On 13/04/2018 16:10, Amaan Cheval wrote:
> On Fri, Apr 13, 2018 at 5:49 AM Chris Johns <chrisj at rtems.org> wrote:
> 
>> ---
>>   c/src/automake/subdirs.am      | 3 ++-
>>   cpukit/automake/subdirs.am     | 3 ++-
>>   testsuites/automake/subdirs.am | 3 ++-
>>   3 files changed, 6 insertions(+), 3 deletions(-)
> 
>> diff --git a/c/src/automake/subdirs.am b/c/src/automake/subdirs.am
>> index 47d88cffcd..ef758f076d 100644
>> --- a/c/src/automake/subdirs.am
>> +++ b/c/src/automake/subdirs.am
>> @@ -29,7 +29,8 @@ $1:
>>          if test "$$$$target" = "all-local"; then \
>>            target="all"; \
>>          fi; \
>> -       echo "Making $$$$target in $$$$subdir"; \
>> +       if test x$(AM_V_P) != x; then silent=$(AM_V_P); else
> silent=false; fi; \
>> +       if $$$$silent; then echo "Making $$$$target in $$$$subdir"; fi; \
> 
> Though this does the right thing, it reads misleadingly - "if silent, then
> echo". Should it be named "verbose", perhaps, or be negated if it's meant
> to be easy to search for "silent" for all instances where the silent
> building takes effect?

Yes it is misleading and it makes sense to change. I will use `verbose`.

> (The latter depends on how AM_V_P is set, which I'm not sure about.)

It depends on the options in the makefile, the configure command line and then
V=? effects the value.

Thank you for the review.

Chris