[PATCH] 5: Use a specific RTEMS tools version

[Chris Johns]

On 17/04/2018 18:21, Sebastian Huber wrote:
> Download via HTTPS RTEMS file server.
> 
> Close 3241.

Can you please explain why this solves the issue in the ticket? I do not see how
they relate.

There can be issues with a sequence of git commands if you are switching
branches. This can be resolved by improving the sequence used.

> ---
>  rtems/config/tools/rtems-tools-5-1.cfg | 28 ++++++++++++++++++++++++++--
>  1 file changed, 26 insertions(+), 2 deletions(-)
> 
> diff --git a/rtems/config/tools/rtems-tools-5-1.cfg b/rtems/config/tools/rtems-tools-5-1.cfg
> index 6efc4e3..e0178f0 100644
> --- a/rtems/config/tools/rtems-tools-5-1.cfg
> +++ b/rtems/config/tools/rtems-tools-5-1.cfg
> @@ -7,9 +7,33 @@
>  #
>  %if %{rsb_released}
>   %define rtems_tools_version %{rsb_version}
> +%else
> + %define rtems_tools_version ec419a05ee52869a7d5b8712ea8e7a7d74fde096
>  %endif

Sorry, this is not the right place for this sort of detail. Version details need
to be in the release defaults or overridden in a an arch specific file.

Why this version?

I do not follow or understand the purpose of the change and with a lack of
specific detail it appears to solve a local problem. It may appear to solve the
problem because it side steps an issue related to switching branches.

>  #
> -# The RTEMS Tools build instructions. We use tools 1.
> +# Optionally enable/disable building the RTEMS Tools via the command line.

Why?

I do not understand the use case?

Chris

>  #
> -%include tools/rtems-tools-1.cfg
> +%if %{defined with_rtems_tools}
> + %define rtems_tools_build 1
> +%endif
> +%if %{defined without_rtems_tools}
> + %define rtems_tools_build 0
> +%endif
> +
> +#
> +# Build by default.
> +#
> +%if ! %{defined rtems_tools_build}
> + %define rtems_tools_build 1
> +%endif
> +
> +%if %{rtems_tools_build}
> + %source set rtems-tools https://ftp.rtems.org/pub/rtems/people/sebh/rtems-tools-%{rtems_tools_version}.tar.bz2
> + %hash sha512 rtems-tools-%{rtems_tools_version}.tar.bz2 af1cda88144583bd9471056291d0a19e8ace0e45efded01e7d32014919a8e57e8a47a58497b2c9201dff925316a8b9cfd0d0e6000f4755471fdf5468b5daa517
> +
> + #
> + # The RTEMS Tools build instructions.
> + #
> + %include tools/rtems-tools-common-1.cfg
> +%endif
>