[PATCH 1/2] covoar: Add symbol set reader and ELF data parser to covoar.

Chris Johns chrisj at rtems.org
Fri Apr 27 07:32:15 UTC 2018


On 27/04/2018 17:21, Cillian O'Donnell wrote:
> On Fri, 27 Apr 2018, 04:48 Chris Johns, <chrisj at rtems.org
> <mailto:chrisj at rtems.org>> wrote:
> 
>     On 27/04/2018 08:51, Joel Sherrill wrote:
>     >
>     >        // Create the set of desired symbols.
>     >        SymbolsToAnalyze = new Coverage::DesiredSymbols();
>     >     -  SymbolsToAnalyze->load( symbolsFile );
>     >
>     >
>     > I am having trouble seeing what happened to the DesiredSymbols class. Is
>     > it no longer needed?
> 
> 
> It's still being used as before, the decision has just been split from did you
> provided the symbols file or are you using symbol_set.cfg file. DesiredSymbols
> is definitely still being used. I'm looking on my phone  so maybe missing
> something that would be clearer not on a phone.

I have renamed a few files, for example ..

 tester/rtems/testing/coverage/symbol_sets.cfg ->
tester/rtems/testing/coverage/score-symbols.ini

and that file now contains:

[symbol-sets]
sets = score

[score]
libraries=@BUILD-PREFIX@/c/@BSP@/cpukit/score/libscore.a

I have added code to get the build path, BUILD-PREFIX and BSP from the
executable's path and check each executable is from the same build tree.

I may check these against the RLD's automatically detected values after loading
the libraries.

I have add the code to load the libraries and the required symbols.

This means some of the code to read the sets and then load the libraries and
create a symbol file can be removed.

I have not attempted to build to the code and will do this over the weekend or
next week.

> Just to update, I didn't get time to look at the rsb build yesterday so it'll
> have to be tonight. Sorry for the delay, my new job keeps me very busy during
> the week, long commutes too.

No problem, when you can.

Thank you.
Chris



More information about the devel mailing list