psxhdrs :Add POSIX API support to <utime.h>

[Joel Sherrill]

I am traveling this week and reviewing as I can. I plan to review and merge
again this evening when I am at my destination.

Please make sure you have no warnings.

If the method has an int return type, return that from the method. If not,
ro something like return (result != VALUE). Often the return type is a
pointer so value would be NULL.

Make sure there is a blank line between the Doxygen block and copyright
block.

And all variables should be local to the test method.

Those seem to be the issues I am seeing in these tasks.

That's all I can do from my phone. About to head to the gate.

--joel

On Sun, Dec 2, 2018, 12:46 PM Shashvat Jain <shashvatjain2002 at gmail.com
wrote:

> here is the updated patch attached
>
> On Sun, Dec 2, 2018 at 8:28 PM Shashvat Jain <shashvatjain2002 at gmail.com>
> wrote:
>
>> Hello ,
>> I just added the test for utime.h header files
>> the patch for the change has been attached here,
>>
>>
>> Thank you
>> Regards
>>
>>
>> ============================================================
>>
>> From 48d40d771c684af848a26efb1fff8a8d6e110c95 Mon Sep 17 00:00:00 2001
>> From: Shashvat Jain <shashvatjain2002 at gmail.com>
>> Date: Sat, 1 Dec 2018 12:57:44 -0500
>> Subject: [PATCH] psxhdrs : Add POSIX API Signature Compliance Tests for
>>  utime.h (GCI 2018)
>>
>> ---
>>  testsuites/psxtests/Makefile.am | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/testsuites/psxtests/Makefile.am
>> b/testsuites/psxtests/Makefile.am
>> index 553b259..8c527a8 100644
>> --- a/testsuites/psxtests/Makefile.am
>> +++ b/testsuites/psxtests/Makefile.am
>> @@ -1069,6 +1069,7 @@ lib_a_SOURCES = psxhdrs/devctl/posix_devctl.c \
>>   psxhdrs/unistd/setsid.c psxhdrs/unistd/setuid.c \
>>   psxhdrs/unistd/sleep.c psxhdrs/unistd/sync.c psxhdrs/unistd/ualarm.c \
>>   psxhdrs/unistd/usleep.c psxhdrs/sys/mman/mlockall.c \
>> +        psxhdrs/utime/utime.c \
>>   psxhdrs/sys/mman/mlock.c psxhdrs/sys/mman/mmap.c \
>>   psxhdrs/sys/mman/mprotect.c psxhdrs/sys/mman/msync.c \
>>   psxhdrs/sys/mman/munlockall.c psxhdrs/sys/mman/munlock.c \
>> --
>> 1.8.3.1
>>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20181202/bbea276d/attachment-0002.html>