[PATCH 1/3] i386/smp: Define unused CPU_Interrupt_frame to fix compiler error

Sebastian Huber sebastian.huber at embedded-brains.de
Mon Mar 12 12:36:09 UTC 2018


On 12/03/18 13:32, Amaan Cheval wrote:
> I originally sent this patch with the intent of merely ridding the i386
> targets of compiler errors, for anyone interested in looking into SMP
> issues on the arch.
>
> Do you believe that I should look into fixing i386's incomplete SMP
> context-switch support for this patch too, or would that be okay as a
> follow-up later, given that it seems like there's more incompleteness
> regarding SMP for i386?

A compile-time error is a good hint that it is broken. I think this is 
more user friendly compared to having to debug a run-time error which 
takes place only under certain conditions.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list