[PATCH 2/3] Add ARM Paravirtualization support

Sebastian Huber sebastian.huber at embedded-brains.de
Tue Mar 13 06:47:29 UTC 2018


On 12/03/18 21:41, Joel Sherrill wrote:
> diff --git a/cpukit/score/cpu/arm/cpu_asm.S b/cpukit/score/cpu/arm/cpu_asm.S
> index f58b99d..39a756c 100644
> --- a/cpukit/score/cpu/arm/cpu_asm.S
> +++ b/cpukit/score/cpu/arm/cpu_asm.S
> @@ -111,9 +111,10 @@ DEFINE_FUNCTION_ARM(_CPU_Context_switch)
>   #endif
>   
>   #ifdef ARM_MULTILIB_HAS_THREAD_ID_REGISTER

Why don't you suppress the ARM_MULTILIB_HAS_THREAD_ID_REGISTER 
definition in case RTEMS_PARAVIRT is defined?

> +  #ifndef ARM_DISABLE_THREAD_ID_REGISTER_USE
>   	mcr	p15, 0, r3, c13, c0, 3
> +  #endif
>   #endif
> -

Please don't delete this blank line. The next statement has nothing to 
do with the thread ID.

>   	str	r4, [r2, #PER_CPU_ISR_DISPATCH_DISABLE]
>   
>   	/* In ARMv5T and above the load of PC is an interworking branch */

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list