[PATCH] Added Getentropy() support to beagle BSP

Sebastian Huber sebastian.huber at embedded-brains.de
Thu Mar 15 06:04:34 UTC 2018



On 15/03/18 05:56, Udit agarwal wrote:
> +/* TRNG Register */
> +
> +/* RNG base address */

Is the module name TRNG or RNG?

> +#define RNG_BASE 0x48310000
> +/* RNG clock control */
> +#define CM_PER_RNG_CLKCTRL (AM335X_CM_PER_ADDR | (9 << 4))

This define is probably not for the TRNG register block. Should it move 
the corresponding register block?

> +/* rng module clock status bits */
> +#define AM335X_CLK_RNG_BIT_MASK (0x30000)
> +/* Offset from RNG base for output ready flag */
> +#define RNG_STATUS_RDY (1u <<  0)
> +/* Offset from RNG base for FRO related error */
> +#define RNG_STATUS_ERR (1u <<  1)
> +/* Offset from RNG base for clock status */
> +#define RNG_STATUS_CLK (1u << 31)

Are these offsets or bits?

> +/* enable module */
> +#define AM335X_RNG_ENABLE (1 << 10)
> +

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list