[PATCH v2 4/6] dhcpcd: Remove unused dhcpcd shell command

[Chris Johns]

I oppose this change.

On 03/05/2018 16:49, Sebastian Huber wrote:
> ---
>  libbsd.py                               |  6 -----
>  rtemsbsd/include/rtems/netcmds-config.h |  2 --
>  rtemsbsd/rtems/rtems-bsd-shell-dhcpcd.c | 40 ---------------------------------
>  3 files changed, 48 deletions(-)
>  delete mode 100644 rtemsbsd/rtems/rtems-bsd-shell-dhcpcd.c
> 
> diff --git a/libbsd.py b/libbsd.py
> index 801873ed6..a62581faa 100644
> --- a/libbsd.py
> +++ b/libbsd.py
> @@ -4587,12 +4587,6 @@ class dhcpcd(builder.Module):
>              ],
>              mm.generator['source']('-D__FreeBSD__ -DTHERE_IS_NO_FORK -DMASTER_ONLY -DINET -DINET6')
>          )
> -        self.addRTEMSSourceFiles(
> -            [
> -                'rtems/rtems-bsd-shell-dhcpcd.c',
> -            ],
> -            mm.generator['source']()
> -        )
>  
>  #
>  # MDNS Responder
> diff --git a/rtemsbsd/include/rtems/netcmds-config.h b/rtemsbsd/include/rtems/netcmds-config.h
> index 4af43231f..ecb4f56a7 100644
> --- a/rtemsbsd/include/rtems/netcmds-config.h
> +++ b/rtemsbsd/include/rtems/netcmds-config.h
> @@ -33,8 +33,6 @@ extern rtems_shell_cmd_t rtems_shell_IFCONFIG_Command;
>  extern rtems_shell_cmd_t rtems_shell_ROUTE_Command;
>  extern rtems_shell_cmd_t rtems_shell_NETSTAT_Command;
>  
> -extern rtems_shell_cmd_t rtems_shell_DHCPCD_Command;
> -
>  extern rtems_shell_cmd_t rtems_shell_HOSTNAME_Command;
>  
>  extern rtems_shell_cmd_t rtems_shell_TCPDUMP_Command;
> diff --git a/rtemsbsd/rtems/rtems-bsd-shell-dhcpcd.c b/rtemsbsd/rtems/rtems-bsd-shell-dhcpcd.c
> deleted file mode 100644
> index 248937489..000000000
> --- a/rtemsbsd/rtems/rtems-bsd-shell-dhcpcd.c
> +++ /dev/null
> @@ -1,40 +0,0 @@
> -/*
> - * Copyright (c) 2013 embedded brains GmbH.  All rights reserved.
> - *
> - *  embedded brains GmbH
> - *  Dornierstr. 4
> - *  82178 Puchheim
> - *  Germany
> - *  <rtems at embedded-brains.de>
> - *
> - * Redistribution and use in source and binary forms, with or without
> - * modification, are permitted provided that the following conditions
> - * are met:
> - * 1. Redistributions of source code must retain the above copyright
> - *    notice, this list of conditions and the following disclaimer.
> - * 2. Redistributions in binary form must reproduce the above copyright
> - *    notice, this list of conditions and the following disclaimer in the
> - *    documentation and/or other materials provided with the distribution.
> - *
> - * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
> - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> - * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
> - * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> - * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> - * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
> - * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> - * SUCH DAMAGE.
> - */
> -
> -#include <rtems/netcmds-config.h>
> -#include <machine/rtems-bsd-commands.h>
> -
> -rtems_shell_cmd_t rtems_shell_DHCPCD_Command = {
> -  .name = "dhcpcd",
> -  .usage = "dhcpcd [args]",
> -  .topic = "net",
> -  .command = rtems_bsd_command_dhcpcd
> -};
>