[PATCH 1/2] covoar/ObjdumpProcessor.cc: Add processing for ... padding notation w/hack

[Gedare Bloom]

On Wed, May 23, 2018 at 11:11 PM, Joel Sherrill <joel at rtems.org> wrote:
>
>
> On Wed, May 23, 2018, 9:59 PM Chris Johns <chrisj at rtems.org> wrote:
>>
>> On 24/5/18 12:07 pm, Joel Sherrill wrote:
>> > ---
>> >  tester/covoar/ObjdumpProcessor.cc | 22 ++++++++++++++++++++++
>> >  1 file changed, 22 insertions(+)
>> >
>> > diff --git a/tester/covoar/ObjdumpProcessor.cc
>> > b/tester/covoar/ObjdumpProcessor.cc
>> > index d41906c..183722b 100644
>> > --- a/tester/covoar/ObjdumpProcessor.cc
>> > +++ b/tester/covoar/ObjdumpProcessor.cc
>> > @@ -384,6 +384,28 @@ namespace Coverage {
>> >          break;
>> >        }
>> >
>> > +      // This string indicates a block of padding at the end of a
>> > method
>> > +      if (!strncmp(line.c_str(), "\t...", 4)) {
>>
>> You have an std::string so why no use C++ rather than resorting to C?
>>
>> For example http://en.cppreference.com/w/cpp/string/basic_string/compare.
>
>
> I was in a hurry and had trouble getting this logic to trip at all. I still
> fix this. It does need to be like strncmp.
>
> The +4 is awful though
Classical technical debt. :)

>>
>>
>> Chris
>> _______________________________________________
>> devel mailing list
>> devel at rtems.org
>> http://lists.rtems.org/mailman/listinfo/devel
>
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel