[PATCH 2/6] or1k/shared/cache/cache.c: Remove unused methods
joel at rtems.org
Mon Oct 8 22:33:21 UTC 2018
On Mon, Oct 8, 2018 at 9:37 AM Martin Erik Werner <
martinerikwerner.aac at gmail.com> wrote:
> On Mon, 2018-10-08 at 15:28 +0200, Sebastian Huber wrote:
> > Are the intentionally unused or is there some bug and the generic cache
> > manager doesn't use them accidentally?
> I think that when I added the range support to the or1k cache helpers I
> left the 1-line functions there since I was unaware that they would be
> completely non-visible to upper layers (right?). As far as I can tell
> they can be removed.
I'm not pushing this change unless you are happy with it.
So I am waiting for a clear yes/no. I was just fixing an obvious warning.
On a random or1k note, I managed to build everything with the new FSF
clean tools last week.
> Whilst looking, I saw that something like this is also present in
> bsps/arm/shared/cache/cache-cp15.c, but
> CPU_CACHE_SUPPORT_PROVIDES_RANGE_FUNCTIONS is set via indirection
> there, so it might be a special case?
> Martin Erik Werner <martinerikwerner.aac at gmail.com>
> ÅAC Microtec AB | Clyde Space Ltd.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the devel