[PATCH 2/6] or1k/shared/cache/cache.c: Remove unused methods

Martin Erik Werner martinerikwerner.aac at gmail.com
Tue Oct 9 09:04:53 UTC 2018


On Mon, 2018-10-08 at 17:33 -0500, Joel Sherrill wrote:
> 
> 
> On Mon, Oct 8, 2018 at 9:37 AM Martin Erik Werner <martinerikwerner.aac at gmail.com> wrote:
> > On Mon, 2018-10-08 at 15:28 +0200, Sebastian Huber wrote:
> > > Are the intentionally unused or is there some bug and the generic cache 
> > > manager doesn't use them accidentally?
> > 
> > I think that when I added the range support to the or1k cache helpers I
> > left the 1-line functions there since I was unaware that they would be
> > completely non-visible to upper layers (right?). As far as I can tell
> > they can be removed.
> 
> I'm not pushing this change unless you are happy with it.  
> 
> So I am waiting for a clear yes/no. I was just fixing an obvious warning.

Yes, do push it.

-- 
Martin Erik Werner <martinerikwerner.aac at gmail.com>
ÅAC Microtec AB | Clyde Space Ltd.



More information about the devel mailing list