[PATCH 4/5] bsps/arm: Unmask generic timer in interrupt handler

[Jeff Kubascik]

On 12/3/2019 1:22 AM, Sebastian Huber wrote:
> On 02/12/2019 19:58, Jeff Kubascik wrote:
>> Xen will mask the virtual timer before injecting the interrupt to the
>> guest.
>> ---
>>   bsps/arm/shared/clock/clock-generic-timer.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/bsps/arm/shared/clock/clock-generic-timer.c b/bsps/arm/shared/clock/clock-generic-timer.c
>> index 1369a5d6f1..cedf1c40fd 100644
>> --- a/bsps/arm/shared/clock/clock-generic-timer.c
>> +++ b/bsps/arm/shared/clock/clock-generic-timer.c
>> @@ -90,6 +90,7 @@ static void arm_gt_clock_at_tick(void)
>>     cval = arm_gt_clock_get_compare_value();
>>     cval += interval;
>>     arm_gt_clock_set_compare_value(cval);
>> +  arm_gt_clock_set_control(0x1);
>>   }
>>
>>   static void arm_gt_clock_handler_install(void)
>>
> 
> Please add an option like this
> 
>   * The BSP may optionally define ARM_GENERIC_TIMER_USE_VIRTUAL in
> <bsp.h> to
>   * use the virtual timer instead of the physical timer.
> 
> to set the control register in arm_gt_clock_at_tick().

Understood, I will create a new option for this Xen workaround. I'm thinking
something like ARM_GENERIC_TIMER_UNMASK_AT_TICK?

> --
> Sebastian Huber, embedded brains GmbH
> 
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de
> PGP     : Public key available on request.
> 
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
> 

Sincerely,
Jeff Kubascik