[PATCH 1/5] bsps/arm: Add zImage boot header

[Jeff Kubascik]

On 12/3/2019 1:30 AM, Sebastian Huber wrote:
> On 02/12/2019 19:58, Jeff Kubascik wrote:
>> Xen currently only supports the zImage loader for 32 bit guests on ARM
>> targets.
>> ---
>>   bsps/arm/shared/start/start.S | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/bsps/arm/shared/start/start.S b/bsps/arm/shared/start/start.S
>> index 0e9e6a0cde..3547ec5a9a 100644
>> --- a/bsps/arm/shared/start/start.S
>> +++ b/bsps/arm/shared/start/start.S
>> @@ -40,6 +40,17 @@
>>
>>       .section        ".bsp_start_text", "ax"
>>
>> +#ifdef BSP_START_ZIMAGE_HEADER
>> +.rept        8
>> +     mov     r0, r0
>> +.endr
>> +     b       after_header
>> +     .word   0x016f2818              /* Magic numbers to help the loader */
>> +     .word   bsp_section_start_begin /* zImage start address */
>> +     .word   bsp_section_data_end    /* zImage end address */
>> +after_header:
> 
> Please use a local label similar to the rest of the file, e.g.
> ".Lafter_header".

After looking at the source file again, this would appear to be the coding
standard! I will make this correction.

> --
> Sebastian Huber, embedded brains GmbH
> 
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de
> PGP     : Public key available on request.
> 
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
> 

Sincerely,
Jeff Kubascik