[PATCH] bsps/powerpc: Fix small data area section

Sebastian Huber sebastian.huber at embedded-brains.de
Mon Feb 11 07:51:27 UTC 2019


On 11/02/2019 08:43, Chris Johns wrote:
> On 11/2/19 7:38 pm, Sebastian Huber wrote:
>> Fix small data area in case no fixed size is desired.
> What is being fixed?

Did you test without setting bsp_section_set_sdata_sbss_size? With 
bsp_section_sdata_sbss_size == 0 the location counter moves backwards here:

. += bsp_section_sdata_sbss_size - (bsp_section_sdata_size + bsp_section_sbss_size);


>
>> Rename
>> bsp_section_set_sdata_sbss_size into bsp_section_small_data_area_size
>> since this symbol reflects the overall small data area size (including
>> space for libdl).
> The naming I used reflected the sections the compiler makes and what is being
> controlled.

You set the size for the small data area (name in the ABI documents). It 
includes the .sdata and .sbss input sections and your libdl part.

>
>>   Do not use bsp_section_sbss_size before definition in
>> linker command file.  Add new symbols to <bsp/linker-symbols.h>.
> Sorry I am having trouble seeing what are style changes and what is a functional
> change to fix the issue.
>
> Thanks
> Chris

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list