[PATCH] bsps/powerpc: Fix small data area section

Chris Johns chrisj at rtems.org
Mon Feb 11 09:31:31 UTC 2019

> On 11 Feb 2019, at 8:51 pm, Sebastian Huber <sebastian.huber at embedded-brains.de> wrote:
>> On 11/02/2019 08:43, Chris Johns wrote:
>>> On 11/2/19 7:38 pm, Sebastian Huber wrote:
>>> Fix small data area in case no fixed size is desired.
>> What is being fixed?
> Did you test without setting bsp_section_set_sdata_sbss_size? With bsp_section_sdata_sbss_size == 0 the location counter moves backwards here:
> . += bsp_section_sdata_sbss_size - (bsp_section_sdata_size + bsp_section_sbss_size);

I thought I had but must have got something wrong. 

>>> Rename
>>> bsp_section_set_sdata_sbss_size into bsp_section_small_data_area_size
>>> since this symbol reflects the overall small data area size (including
>>> space for libdl).
>> The naming I used reflected the sections the compiler makes and what is being
>> controlled.


> You set the size for the small data area (name in the ABI documents). It includes the .sdata and .sbss input sections and your libdl part.

Some of this would great in a comment :)


More information about the devel mailing list