GSoC Project | Basic Support for Trace Compass

[Sebastian Huber]

On 04/07/2019 08:36, Ravindra Kumar Meena wrote:
>     This change isn't right. We want to use the file per CPU exactly to get
>     rid of this member.
>      >
>     https://github.com/rmeena840/rtems-tools/commit/582b999b135ddcbc1fc88a9ee2b302fe811382a7
>      >
>      > I have added cpu_id in ctf_event so that babeltrace knows that which
>      > cpu_id is it reading.
> 
>     In your metadata you removed the cpu member from the event structure.
> 
> I removed it because the new binary stream file does not have CPU. It 
> has only three values ns, event, and data.

In commit 582b999b135ddcbc1fc88a9ee2b302fe811382a7 we have:

typedef struct ctf_event {
   uint32_t                     cpu_id;
   uint64_t                     ns;
   rtems_record_event           event;
   uint64_t                     data;
} ctf_event;

So, the new binary stream is not new, it still has the CPU member!

The CPU member must move to the packet header. The packet header tells 
the consumer (e.g. babeltrace): the following events of this packet all 
belong to this CPU.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.