[PATCH v2] Add mmap

Sebastian Huber sebastian.huber at embedded-brains.de
Wed Jul 17 04:56:35 UTC 2019


On 16/07/2019 21:47, Vijay Kumar Banerjee wrote:
> +	rv = mmap(NULL, 1, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
> +	assert(rv != MAP_FAILED);
> +

Please change this to:

assert(rv == 0);

Please add assertions for the flags (PROT*, MAP*) to your mmap handler.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.



More information about the devel mailing list