[PATCH v2] Add mmap

[Vijay Kumar Banerjee]

On Wed, Jul 17, 2019 at 10:26 AM Sebastian Huber <
sebastian.huber at embedded-brains.de> wrote:

> On 16/07/2019 21:47, Vijay Kumar Banerjee wrote:
> > +     rv = mmap(NULL, 1, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
> > +     assert(rv != MAP_FAILED);
> > +
>
> Please change this to:
>
> assert(rv == 0);
>
> Please add assertions for the flags (PROT*, MAP*) to your mmap handler.
>
> Thanks for the review.
I have fixed this in v3 of the patch:
https://lists.rtems.org/pipermail/devel/2019-July/026650.html

> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de
> PGP     : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20190717/8c3d7924/attachment-0002.html>