[PATCH 2/2] sparc: Fix mistakenly cleared PSR[EF] bit.

Sebastian Huber sebastian.huber at embedded-brains.de
Thu Jun 6 06:57:49 UTC 2019



On 05/06/2019 21:22, Maksim E. Kozlov wrote:
> ---
>   cpukit/score/cpu/sparc/cpu_asm.S | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/cpukit/score/cpu/sparc/cpu_asm.S b/cpukit/score/cpu/sparc/cpu_asm.S
> index 2f3ad24510..69bbfb2748 100644
> --- a/cpukit/score/cpu/sparc/cpu_asm.S
> +++ b/cpukit/score/cpu/sparc/cpu_asm.S
> @@ -682,10 +682,11 @@ isr_dispatch:
>           ld      [%g6 + SPARC_PER_CPU_FP_OWNER_OFFSET], %l7
>           cmp     %l6, %l7
>           bne     .Ldisable_fp
> -         andn   %l0, %l5, %l0
> +         nop

Wouldn't it be sufficient to change this to

bne,a .Ldisable_fp
  andn %l0, %l5, %l0

?

>           ba      .Lthread_dispatch_done
>            st     %g0, [%g6 + SPARC_PER_CPU_FP_OWNER_OFFSET]
>   .Ldisable_fp:
> +        andn   %l0, %l5, %l0
>           ba      .Lthread_dispatch_done
>            st      %l0, [%fp + ISF_PSR_OFFSET]
>   .Lnon_fp_thread_dispatch:

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list