[PATCH v2] Comment added

[Sebastian Huber]

On 16/06/2019 20:13, Ravindra Meena wrote:
> ---
>   misc/CTF/record-ctf.ref | 55 +++++++++++++++++++++++++++++++++----------------
>   1 file changed, 37 insertions(+), 18 deletions(-)
> 
> diff --git a/misc/CTF/record-ctf.ref b/misc/CTF/record-ctf.ref
> index a27757c..bdb9648 100644
> --- a/misc/CTF/record-ctf.ref
> +++ b/misc/CTF/record-ctf.ref
[...]
>   clock {
> -    name = ctf_clock;
> -    freq = 1000;
> -    offset_s = 1421703448;
> +    name = ctf_clock; /* name of montonic clock */
> +    freq = 1000; /* frequency, in HZ */

Why 1000Hz?

> +    offset_s = 1421703448;

What is this for an offset?

>   };
>   
> +/*
> + *  A reference to the clock added within an integer type
> + */
> +
>   typealias integer {
>       size = 64;
>       map = clock.ctf_clock.value;
>   } := ctf_clock_int_t;

Why does this start with "ctf_"?

>   
> +/*
> + * Trace stream packet having header and context.
> + *
> + * @param event.header includes id(unique identifier of stream) and timestamp.
> + * @param packet.context includes clock timestamp, cpu id, event and event data.
> + */
> +
>   stream {
>       id = 0;
> +    event.header := struct {
> +        uint32_t id;

What is this for an id?

> +        ctf_clock_int_t timestamp;

Timestamp of what?

> +    };
>       packet.context := struct {
>   		ctf_clock_int_t timestamp;
>   		uint32_t cpu;
>   		uint32_t event;
>   		uint64_t data;
>       };
> -    event.header := struct {
> -        uint32_t id;
> -        ctf_clock_int_t timestamp;
> -    };
>   };
>   
>   event {
> -    id = 0;
> -    name = "ctf_event";
> -    stream_id = 0;
> +    id = 0; /* event id
> +    name = "ctf_event"; /* event name */
> +    stream_id = 0; /* signifies stream id which event is supposed to concat with events */
>       fields := struct {
> -        uint32_t a;
> -        uint16_t b;
> -        string c;
> +        uint32_t a; /*event 1*/
> +        uint16_t b; /*event 2*/
> +        string c; /*event 3*/

What are events 1, 2, 3?

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.