[PATCH 2/2] rcmd.c: Removed references to unsupported functions

Sebastian Huber sebastian.huber at embedded-brains.de
Tue May 7 05:02:06 UTC 2019


On 06/05/2019 15:48, dufault at hda.com wrote:
>
>
>> On May 6, 2019, at 01:02 , Sebastian Huber 
>> <sebastian.huber at embedded-brains.de 
>> <mailto:sebastian.huber at embedded-brains.de>> wrote:
>>
>> On 05/05/2019 03:00, Chris Johns wrote:
>>> On 5/5/19 12:21 am, Joel Sherrill wrote:
>>>> Sorry for missing that it actually was referenced
>>>>
>>>> Rcmd can and should work. Rcmdsh will not ever and should be 
>>>> removed from libbsd.
>>>>
>>>> Does rcmd need testing? It clearly had no test since it wouldn't 
>>>> have linked.
>>>
>>> Yes that would be great. Testing libbsd is a complicated.
>>
>> If it is used by applications it should be tested, otherwise we 
>> should remove it from the build to make it a little faster and reduce 
>> the maintenance costs of libbsd.
>
> It is used.  The use may be removed (this is a port from vxWorks) but 
> as part of a baseline it is used.

If something is used in applications, then please add unit tests for it. 
I tend to remove untested stuff that makes trouble during updates.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list