rtems-tester initial port getting "'NoneType' object is not iterable"

[Kinsey Moore]

> -----Original Message-----
> From: devel <devel-bounces at rtems.org> On Behalf Of dufault at hda.com
> Sent: Saturday, September 21, 2019 08:48
> To: Joel Sherrill <joel at rtems.org>
> Cc: rtems-devel at rtems.org <devel at rtems.org>
> Subject: Re: rtems-tester initial port getting "'NoneType' object is not iterable"
> 
> 
> 
> > On Sep 20, 2019, at 21:43 , Joel Sherrill <joel at rtems.org> wrote:
> >
> >
> >
> > On Fri, Sep 20, 2019, 8:21 PM Chris Johns <chrisj at rtems.org> wrote:
> > On 21/9/19 5:56 am, dufault at hda.com wrote:
> > > One thing I should have said is that “rtems" and "rtems-tester" are the
> master branches, "rtems-tester" is updated as of yesterday, and “rtems” is
> recent.
> >
> > Thanks.
> >
> > >
> > >> On Sep 20, 2019, at 15:46 , Peter Dufault <dufault at hda.com> wrote:
> > >>
> > >> I’m bringing up the rtems-tester for the PowerPC “beatnik” bsp.  I’m
> impressed with how easy it is to implement (well done, Chris).
> >
> > Thanks, it is good to get this type of feedback and things are just working.
> >
> > > But after doing all the easy work, and just as I thought my initial run of the
> “samples" was about to exit successfully, the script faulted and gave me the
> error "TypeError: 'NoneType' object is not iterable”.  I’ve pasted the output of
> my run below.
> >
> > OK.
> >
> > >> Average test time: 0:00:40.583694
> >
> > Does this target take a bit of time to boot?
> 
> There’s at least 16 seconds overhead - 2 seconds in the power off / on, about 7
> seconds before the MOTLOAD monitor visibly starts (probably testing), and a 7
> second delay (that I now see I can change, I’ll lower it to 1) where it is letting
> you hit <ESC> to skip the auto-boot.
> 
> >
> > >> Testing time     : 0:09:28.171711
> > >> Traceback (most recent call last):
> > >>  File "../rtems-tools/tester/rt/cmd-test.py", line 42, in <module>
> > >>    test.run(sys.argv[1:], command_path = base)  File
> > >> "/home/dufault/development/rtems/rtems-tools/tester/rt/test.py", line
> 455, in run
> > >>    for report_format in report_formats:
> > >> TypeError: 'NoneType' object is not iterable
> >
> > This is from Kinsey patch where report formats was added....
> >
> > https://git.rtems.org/rtems-tools/commit/?id=5fcaf843bdb491e2da14dc1af
> > 61806ac6d20bae5
> >
> >
> > Joel?
> >
> > Sorry I was traveling home today. I have good news to pass along later.
> >
> > I will get Kinsey to look at this. Peter can you email us the configuration file?
> 
> Here’s the global “.ini” file, rtems-tools/tester/rtems/testing/bsps/beatnik.ini.  I
> notice I should change the reset expressikno to be any error status ("^Error
> Status: " is enough to indicate a problem).
> 
> #
> # This is for the MVME5500 PowerPC VME board running the "beatnik" BSP.
> # - The console is connected to a telnet tty device.
> # - The system is running MOTLoad RTOS Version 2.0,  PAL Version 2.5 RM01 # -
> The system is connected to ethernet and is booted via TFTP.
> #
> [beatnik]
> bsp                = beatnik
> arch               = powerpc
> tester             = %{_rtscripts}/tftp.cfg
> jobs               = 1
> test_restarts      = 3
> target_reset_regex = ^Error Status: 00000081 target_start_regex =
> ^MVME5500>
> requires           = target_on_command, target_off_command,
> target_reset_command, bsp_tty_dev
> 
> Here’s my site “.ini” file.
> - beatnik-mkbin is a shell script that does this: "powerpc-rtems5-objcopy -
> Obinary ${from} ${to}” to create a “.bin” from a “.exe”;
> - power-ctl is a shell script that manipulates a network power switch;
> - The console runs at 9600 baud and uses a raspberry PI named “swlab-term”
> running ser2net at port 2000.
> 
> [beatnik]
> tftp_port              = 3822
> bsp_tty_dev            = swlab-term:2000
> target_pretest_command = ./beatnik-mkbin @EXE@
> target_exe_filter      = /\.exe/.bin/
> target_on_command      = ./power-ctl 1 off-on
> target_off_command     = ./power-ctl 1 off
> target_reset_command   = ./power-ctl 1 off-on
> 
> Peter
> -----------------
> Peter Dufault
> HD Associates, Inc.      Software and System Engineering


This bug appears to have snuck in when I refactored the patch for the future handling of multiple report types. I'll have a patch up shortly.

Kinsey