[PATCH v2 3/3] score: Delete RTEMS_DECLARE_GLOBAL_SYMBOL()

[Gedare Bloom]

This looks better to me.

On Tue, Apr 7, 2020 at 2:57 AM Sebastian Huber
<sebastian.huber at embedded-brains.de> wrote:
>
> Delete unused RTEMS_DECLARE_GLOBAL_SYMBOL().
>
> Update #3799.
> ---
>  cpukit/include/rtems/score/basedefs.h | 20 --------------------
>  testsuites/sptests/spmisc01/init.c    |  7 -------
>  2 files changed, 27 deletions(-)
>
> diff --git a/cpukit/include/rtems/score/basedefs.h b/cpukit/include/rtems/score/basedefs.h
> index 0a4ac8e415..67250773e7 100644
> --- a/cpukit/include/rtems/score/basedefs.h
> +++ b/cpukit/include/rtems/score/basedefs.h
> @@ -359,26 +359,6 @@
>    #define RTEMS_DEFINE_GLOBAL_SYMBOL( _name, _value )
>  #endif
>
> -/**
> - * @brief Defines a global symbol with the specified name in the specified
> - * section.
> - *
> - * The name must be a valid designator.  The alignment of the symbol depends on
> - * the current location counter of the section.
> - */
> -#if defined(__GNUC__)
> -  #define RTEMS_DEFINE_GLOBAL_SYMBOL_IN_SECTION( _name, _section ) \
> -    __asm__( \
> -      ".pushsection \"" _section "\"\n" \
> -      "\t.globl " \
> -      RTEMS_XSTRING( RTEMS_SYMBOL_NAME( _name ) ) "\n" \
> -      RTEMS_XSTRING( RTEMS_SYMBOL_NAME( _name ) ) ":\n" \
> -      "\t.popsection\n" \
> -    )
> -#else
> -  #define RTEMS_DEFINE_GLOBAL_SYMBOL_IN_SECTION( _name, section )
> -#endif
> -
>  /**
>   * @brief Returns the value of the specified integral expression and tells the
>   * compiler that the predicted value is true (1).
> diff --git a/testsuites/sptests/spmisc01/init.c b/testsuites/sptests/spmisc01/init.c
> index 8d713c4219..9090069973 100644
> --- a/testsuites/sptests/spmisc01/init.c
> +++ b/testsuites/sptests/spmisc01/init.c
> @@ -99,10 +99,6 @@ RTEMS_DECLARE_GLOBAL_SYMBOL(a_global_symbol);
>
>  RTEMS_DEFINE_GLOBAL_SYMBOL(a_global_symbol, 0xabc);
>
> -RTEMS_DECLARE_GLOBAL_SYMBOL(a_second_symbol);
> -
> -RTEMS_DEFINE_GLOBAL_SYMBOL_IN_SECTION(a_second_symbol, ".rtemsroset.dummy");
> -
>  RTEMS_STATIC_ASSERT(0 != 1, zero_neq_one);
>
>  static int array[3];
> @@ -215,9 +211,6 @@ static void Init(rtems_task_argument arg)
>    rtems_test_assert(printflike_func("%i", 0) == 56);
>    rtems_test_assert(obfuscate_variable(63) == 63);
>    rtems_test_assert((uintptr_t)a_global_symbol == 0xabc);
> -  p = a_second_symbol;
> -  RTEMS_OBFUSCATE_VARIABLE(p);
> -  rtems_test_assert((uintptr_t)p != 0);
>    rtems_test_assert(RTEMS_ARRAY_SIZE(array) == 3);
>    rtems_test_assert(sizeof(zero_length_array_struct) == 4);
>    container_of();
> --
> 2.16.4
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel