[PATCH v2] test for timer_create,Ticket #3889

[Gedare Bloom]

Thanks. Your commit messages need a little fixing.

Create the commit message in text editor, not the command line.

Put first line as the "Short commit" then put a blank line, then put
some extra description if needed, then a blank line if you added extra
description, and somewhere add the ticket as either:
"Updates #nnnn."
or
"Closes #nnnn."
There are a few other verbs that work instead of updates/closes, but
those are what I use.

ask if you need more direction

On Sat, Apr 18, 2020 at 11:04 AM Eshan dhawan <eshandhawan51 at gmail.com> wrote:
>
> This will create a timer using timer_create() method and passing
> CLOCK_MONOTONIC. But it will fail as there is no support for
> CLOCK_MONOTONIC in psxtimercreate.c.
>
> ---
>  testsuites/psxtests/psxtimer02/psxtimer.c     | 8 ++++++--
>  testsuites/psxtests/psxtimer02/psxtimer02.scn | 3 ++-
>  2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/testsuites/psxtests/psxtimer02/psxtimer.c b/testsuites/psxtests/psxtimer02/psxtimer.c
> index 9f79d33c42..e071f98857 100644
> --- a/testsuites/psxtests/psxtimer02/psxtimer.c
> +++ b/testsuites/psxtests/psxtimer02/psxtimer.c
> @@ -62,9 +62,9 @@ void *POSIX_Init (
>    status = timer_create( CLOCK_REALTIME, &event, NULL );
>    fatal_posix_service_status_errno( status, EINVAL, "bad timer id" );
>
> -  puts( "timer_create - OK" );
> +  puts( "timer_create (CLOCK_REALTIME) - OK" );
>    status = timer_create( CLOCK_REALTIME, NULL, &timer );
> -  posix_service_failed( status, "timer_create OK" );
> +  posix_service_failed( status, "timer_create (CLOCK_REALTIME)" );
>
>    puts( "timer_create - too many - EAGAIN" );
>    status = timer_create( CLOCK_REALTIME, NULL, &timer1 );
> @@ -127,6 +127,10 @@ void *POSIX_Init (
>    status = timer_delete( timer );
>    fatal_posix_service_status_errno( status, EINVAL, "bad id" );
>
> +  puts( "timer_create (CLOCK_MONOTONIC) - OK" );
> +  status = timer_create( CLOCK_MONOTONIC, NULL, &timer );
> +  posix_service_failed( status, "timer_create (CLOCK_MONOTONIC)" );
> +
>    TEST_END();
>    rtems_test_exit (0);
>  }
> diff --git a/testsuites/psxtests/psxtimer02/psxtimer02.scn b/testsuites/psxtests/psxtimer02/psxtimer02.scn
> index e78425a32e..7429bcf291 100644
> --- a/testsuites/psxtests/psxtimer02/psxtimer02.scn
> +++ b/testsuites/psxtests/psxtimer02/psxtimer02.scn
> @@ -1,7 +1,7 @@
>  *** POSIX Timers Test 02 ***
>  timer_create - bad clock id - EINVAL
>  timer_create - bad timer id pointer - EINVAL
> -timer_create - OK
> +timer_create (CLOCK_REALTIME) - OK
>  timer_create - too many - EAGAIN
>  timer_delete - bad id - EINVAL
>  timer_getoverrun - bad id - EINVAL
> @@ -13,4 +13,5 @@ timer_settime - bad itimer value - negative nanosecond - EINVAL
>  timer_settime - bad clock value - EINVAL
>  timer_delete - OK
>  timer_delete - bad id - EINVAL
> +timer_create (CLOCK_MONOTONIC) - OK
>  *** END OF POSIX Timers Test 02 ***
> --
> 2.17.1
>