[PATCH] fix Wunused-function deleting unused static functions in dl_tests
Gedare Bloom
gedare at rtems.org
Wed Aug 5 15:50:19 UTC 2020
On Wed, Aug 5, 2020 at 5:52 AM Aschref Ben-Thabet
<aschref.ben-thabet at embedded-brains.de> wrote:
>
> From: Aschref Ben Thabet <aschref.ben-thabet at embedded-brains.de>
>
> the functions dl_close and dl_call are not needed for this test,
> deleting them will avoid the warning of Wunused-function.
> ---
> testsuites/libtests/dl10/dl-load.c | 21 ---------------------
> 1 file changed, 21 deletions(-)
>
> diff --git a/testsuites/libtests/dl10/dl-load.c b/testsuites/libtests/dl10/dl-load.c
> index dee1d6e9cc..a9d60a7e5a 100644
> --- a/testsuites/libtests/dl10/dl-load.c
> +++ b/testsuites/libtests/dl10/dl-load.c
> @@ -96,27 +96,6 @@ static void* dl_load_obj(const char* name, bool has_unresolved)
> return handle;
> }
>
> -static void dl_close (void* handle)
> -{
> - int r;
> - printf ("handle: %p closing\n", handle);
> - r = dlclose (handle);
> - if (r != 0)
> - printf("dlclose failed: %s\n", dlerror());
> - rtems_test_assert (r == 0);
> -}
> -
> -static int dl_call (void* handle, const char* func)
> -{
> - call_sig call = dlsym (handle, func);
> - if (call == NULL)
> - {
> - printf("dlsym failed: symbol not found: %s\n", func);
> - return 1;
> - }
> - call ();
> - return 0;
> -}
>
This looks like it will leave 2 blank lines in a row, after deletion.
Delete one of the blank lines also. send revision with -v2.
> int dl_load_test(void)
> {
> --
> 2.26.2
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
More information about the devel
mailing list