[PATCH] common: Remove probably superfluous import

Chris Johns chrisj at rtems.org
Mon Aug 10 09:26:46 UTC 2020


On 10/8/20 6:48 pm, Sebastian Huber wrote:
> On 10/08/2020 10:41, Chris Johns wrote:
> 
>> On 8/7/20 2:33 pm, Sebastian Huber wrote:
>>> On 08/07/2020 03:11, Chris Johns wrote:
>>>
>>>> On 7/7/20 3:29 pm, Sebastian Huber wrote:
>>>>> The purpose of this import is unclear.
>>>>>
>>>>> This import caused the following error with Sphinx 3.0:
>>>>>
>>>>> Extension error:
>>>>> Could not import extension rtemsdomain (exception: cannot import name 'l_')
>>>>> ---
>>>>>    common/rtemsdomain.py | 1 -
>>>>>    1 file changed, 1 deletion(-)
>>>>>
>>>>> diff --git a/common/rtemsdomain.py b/common/rtemsdomain.py
>>>>> index 49d0728..9b092a3 100644
>>>>> --- a/common/rtemsdomain.py
>>>>> +++ b/common/rtemsdomain.py
>>>>> @@ -3,7 +3,6 @@ from docutils.parsers.rst import directives
>>>>>      from sphinx import addnodes
>>>>>    from sphinx.roles import XRefRole
>>>>> -from sphinx.locale import l_, _
>>>> Is this backwards compatible?
>>> It seems to work also with Sphinx 2.4. I didn't find uses of "l_" and "_" in the
>>> file.
>> Please push.
> It is already pushed to the master. Do you want it also on another branch?

Yes I think it should be given the need for Python3 and the latest Sphinx for
maths rendering.

Thanks
Chris


More information about the devel mailing list