[PATCH 2/2] Psxtest : Fix String Turncation warning

Aschref Ben-Thabet aschref.ben-thabet at embedded-brains.de
Wed Aug 12 15:10:41 UTC 2020


From: Aschref Ben Thabet <aschref.ben-thabet at embedded-brains.de>

replace strncpy with strdup to silence this warning since it tries to
allocate enough memory to hold the old string (plus a '\0' character
to mark the end of the string).
---
 testsuites/psxtests/psxndbm01/init.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/testsuites/psxtests/psxndbm01/init.c b/testsuites/psxtests/psxndbm01/init.c
index b524aff0df..d862f1d7f3 100644
--- a/testsuites/psxtests/psxndbm01/init.c
+++ b/testsuites/psxtests/psxndbm01/init.c
@@ -216,11 +216,8 @@ rtems_task Init(rtems_task_argument ignored)
   get_phone_no = dbm_fetch( db, name2 );
   rtems_test_assert( strcmp( (const char*)get_phone_no.dptr, PHONE_NO2 ) == 0 );
 
-  puts( "Fetch non-existing record and confirm error." );
-  test_strings = (char*)malloc(6);
-  memcpy( test_strings, "Hello", 5 );
-
-  test_strings[5] = '\0';
+  puts( "Fetch non-existing record and confirm error." ); 
+  test_strings = strdup( "Hello");
 
 /* The data pointed by test_string is now pointed by key.dptr */
   key.dptr = test_strings;
-- 
2.26.2



More information about the devel mailing list