[PATCH] sb: Use shebang env python

Chris Johns chrisj at rtems.org
Thu Aug 27 04:35:32 UTC 2020


On 27/8/20 1:10 am, Gedare Bloom wrote:
> thanks, some of this is rewriting shell script to python, and fixing
> up imports. I'd prefer to have these separated, but it's probably fine
> I took a quick skim over all of it.

Changes to the imports are needed for the moved code to work. The code before I
moved to the script wrapper used the system path to manage the loading however I
always felt this was a hack and I was reluctant to use it again.

I tested Python3 and Python2 and when commiting the changes I noticed the file
`source-builder/sb/__init__.py` I had added when playing with options was empty
so I removed. It was empty so what purpose did it serve? It turns out this file
is needed on Python2. I failed to retest after removing the file. I am sorry for
the disruption it has caused.

I have made some other changes to the imports, one to break a circular reference
between the setbulder and reports modules. This appeared as part of cleaning up
how imports are handled. I will post a patch for testing soon.

Chris


More information about the devel mailing list