[PATCH v3] zynq-uart: Fix set_attributes implementation

[Kinsey Moore]

From: Gedare Bloom <gedare at rtems.org>
Sent: Thursday, December 3, 2020 12:51
To: Kinsey Moore <kinsey.moore at oarcorp.com>
Cc: devel at rtems.org
Subject: Re: [PATCH v3] zynq-uart: Fix set_attributes implementation

On Thu, Dec 3, 2020 at 9:46 AM Gedare Bloom <gedare at rtems.org<mailto:gedare at rtems.org>> wrote:

On Thu, Dec 3, 2020 at 8:25 AM Kinsey Moore <kinsey.moore at oarcorp.com<mailto:kinsey.moore at oarcorp.com>> wrote:

+    {
+    case CS6:
+      mode |= ZYNQ_UART_MODE_CHRL(ZYNQ_UART_MODE_CHRL_6);
+      break;
+    case CS7:
+      mode |= ZYNQ_UART_MODE_CHRL(ZYNQ_UART_MODE_CHRL_7);
+      break;
+    case CS8:
          case 0:
+      mode |= ZYNQ_UART_MODE_CHRL(ZYNQ_UART_MODE_CHRL_8);
+      break;
+    default:
+      return false;
One more thing, I think this default case is dead code and can be removed.

That’s there to catch use of character size 5 which isn’t supported by the Cadence/Zynq UART driver.

Kinsey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20201203/665ec58e/attachment-0001.html>