[PATCH] drvmgr: Fix determination of prefix in grlib uart driver

Jan Sommer jan.sommer at dlr.de
Wed Feb 12 14:09:39 UTC 2020


From: Dennis Pfau <dennis.pfau at dlr.de>

drvmgr_get_dev_prefix returns 0 if a prefix was found.
Therefore the if condition needs to check for 0, i.e. DRVMGR_OK.
---
 bsps/shared/grlib/uart/apbuart_cons.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bsps/shared/grlib/uart/apbuart_cons.c b/bsps/shared/grlib/uart/apbuart_cons.c
index ee635e6944..e4d026a4cc 100644
--- a/bsps/shared/grlib/uart/apbuart_cons.c
+++ b/bsps/shared/grlib/uart/apbuart_cons.c
@@ -321,7 +321,7 @@ int apbuart_init1(struct drvmgr_dev *dev)
 	priv->condev.fsname = NULL;
 	/* Get Filesystem name prefix */
 	prefix[0] = '\0';
-	if (drvmgr_get_dev_prefix(dev, prefix)) {
+	if (drvmgr_get_dev_prefix(dev, prefix) == DRVMGR_OK) {
 		/* Got special prefix, this means we have a bus prefix
 		 * And we should use our "bus minor"
 		 */
-- 
2.17.1



More information about the devel mailing list